Repository navigation
Write the RSS feed directly instead of through the feed package - #45
Merged
Merged
Conversation
The RSS feed is built with the feed package, which pulls in sax through xml-js. sax is licensed under BlueOak-1.0.0, which would be good to remove from the site's dependencies since it's not an approved license. This commit builds the RSS 2.0 XML in pages/feed.xml.tsx and drops feed. The output keeps the same channel fields, items, ordering, and indentation, with titles and descriptions in CDATA and all other text XML-escaped. The channel's <generator> element named the feed package, so it was also removed. Signed-off-by: Jared Watts <jbw976@gmail.com>
Contributor
Author
|
Now that the Vercel preview site is up on https://modelplane-n70md9v7r-upboundio.vercel.app/, I compared the preview's feed against the live prod site feed. They match exactly, except for the differences we expected:
But there's also a v0.5 blog post that shows up in the preview site feed, probably because that post still has Every other post comes through the same, e.g. with the same fields and ordering 🙌 |
negz
approved these changes
Oct 30, 2026
negz
left a comment
negz
left a comment
Contributor
There was a problem hiding this comment.
I don't read typescript well but I can't see any obvious issues.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The RSS feed is built with the
feedpackage, which pulls in thesaxpackage. sax is licensed under BlueOak-1.0.0, which would be good to remove from the site's dependencies since it's not an explicitly approved license and I haven't seen any exceptions granted for it yet.This PR basically builds the RSS 2.0 XML manually in
pages/feed.xml.tsxand drops thefeedpackage dependency. This logic is not very complex, so I've opted to implement it directly inline, which I think is a reasonable trade-off here for fewer possible license headaches.I've verified with a locally built site that the RSS output stays exactly the same against the live production site, except for two things: the
lastBuildDatetimestamp, which is set on every request, and the channel's<generator>element, because that named/credited thefeedpackage, which we aren't using anymore. We no longer emit this element.I will also compare the RSS feed output on the vercel preview site when that's ready.
Checklist
npm run lintandnpm run buildlocally.npm run validate-postsif I changed blog content.git commit -s.