fix: preserve selected subtitle colors - #210
Merged
Merged
Conversation
Signed-off-by: LauraGPT <18321252+LauraGPT@users.noreply.github.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TextClippathSubtitlesCliptiming, bottom-center placement, clipping, and FFmpeg video encodingContext
Related to #135. Two users reported that every subtitle color choice exported as white. The UI value already reached
TextClip(color=font_color), so this change removes the external rasterizer from that contract and produces a transparent RGBA clip with the selected color directly.This PR deliberately does not close #135. The issue should remain open until a reporter verifies an exported video in their original environment.
Verification
mainbecause no deterministic subtitle renderer existed24 passedacross subtitle rendering, release contract, recognition compatibility, and duplicate-text matchingpy_compilepassed for the renderer and video clipperpip checkreported no broken requirements on MoviePy 1.0.3 / NumPy 1.26.4 / Pillow 12.3.0git diff --checkpassedExact signed+DCO head:
c0d390d238b539030719533e9b702872284be3d6.