feat: React version of M3TextField #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmath10
requested changes
Jun 22, 2024
Contributor
cmath10
left a comment
cmath10
left a comment
There was a problem hiding this comment.
В целом бы еще пройтись по вызовам React.* и импортировать вещи отдельно. Еще было бы неплохо дополнить storybook, думаю аналогичную доку пока сделать, как в m3-vue рабочем пространстве.
| @@ -0,0 +1,149 @@ | |||
| import React, { useState, useEffect, useRef, HTMLAttributes } from 'react'; | |||
Contributor
There was a problem hiding this comment.
Тут бы разделить импорт типов и импорт хуков. Еще стоит убрать импорт React, лучше импортировать FC отдельно, чтобы при сборке лучше работал treeshaking
| const [focused, setFocused] = useState(false); | ||
| const inputElement = useRef<HTMLInputElement | HTMLTextAreaElement | null>(null); | ||
|
|
||
| const onInput = (event: React.ChangeEvent<HTMLInputElement | HTMLTextAreaElement>) => { |
Contributor
There was a problem hiding this comment.
Тут надо бы использовать хук useCallback, иначе при перерисовке будет заново создаваться. Еще надо бы отдельно импортировать тип ChangeEvent. Аналогично для остальных обработчиков
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.