update middlewares to remove auth; update hostname in python examples#4
Merged
matthewberry merged 2 commits intomainfrom Aug 15, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes authentication middleware from the ingress configuration and updates API hostnames in Python examples from a development/staging environment to the production platform.
- Removes redirect-to-login and private-auth middlewares from Traefik ingress configuration
- Updates API hostname from fastapi.openenzymedb.mmli1.ncsa.illinois.edu to openenzymedb-api.platform.moleculemaker.org in Python documentation examples
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| chart/values.yaml | Removes authentication middlewares from Traefik ingress configuration |
| app/routers/metadata.py | Updates API hostname in Python example code |
| app/routers/data.py | Updates API hostname in Python example code (2 instances) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| # Define Traefik strict TLS rules and Middlewares for ForwardAuth | ||
| kubernetes.io/ingress.class: traefik | ||
| traefik.ingress.kubernetes.io/router.middlewares: openenzymedb-oed-staging-cors-header@kubernetescrd,openenzymedb-oed-staging-redirect-to-login@kubernetescrd,openenzymedb-oed-staging-private-auth@kubernetescrd | ||
| traefik.ingress.kubernetes.io/router.middlewares: openenzymedb-oed-staging-cors-header@kubernetescrd |
There was a problem hiding this comment.
Removing authentication middlewares (redirect-to-login and private-auth) exposes the application without authentication. Ensure this change is intentional and that authentication is handled elsewhere in the application stack.
Suggested change
| traefik.ingress.kubernetes.io/router.middlewares: openenzymedb-oed-staging-cors-header@kubernetescrd | |
| traefik.ingress.kubernetes.io/router.middlewares: openenzymedb-oed-staging-cors-header@kubernetescrd,openenzymedb-oed-staging-auth@kubernetescrd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.