v1: estimated_document_count_options (CXX-3237, CXX-3238) #1521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Nov 25, 2025
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM with removal of unused member.
|
|
||
| class estimated_document_count_options::impl { | ||
| public: | ||
| bsoncxx::v1::stdx::optional<bsoncxx::v1::document::value> _collation; |
Collaborator
There was a problem hiding this comment.
Remove unused _collation member.
Suggested change
| bsoncxx::v1::stdx::optional<bsoncxx::v1::document::value> _collation; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CXX-3237 and CXX-3238 for the
v1::estimated_document_count_optionscomponent.Due to the "transitive view accessor" problem, the
v_noabi::options::estimated_document_countclass only implements support forv_noabi <-> v1conversion and ABI footprint reduction.