This repository was archived by the owner on Oct 4, 2021. It is now read-only.
Open
Conversation
Member
|
Can ProtobuildStandardDefinition be a subclass of DotNetProject? |
Contributor
Author
|
No, because we need to swap out the DotNetProject instance when the current platform changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #1160.
In Protobuild, we want auto-completion and text highlighting to work in C# documents when they're opened. But the types of projects in the solution are
ProtobuildStandardDefinition, notCSharpProjectorDotNetProject.To support this, we need to have a
GetRealProjectmethod, which the type systems and text highlighters can use to get the actual underlying project. The value of this method will change whenever the active configuration changes.This doesn't cover everywhere I need to intercept this value; when I open a Protobuild project in MonoDevelop it still raises errors in text files about System.Object not being loaded. If someone could point me any other locations I might missing to make this work, that'd be appreciated.