This repository was archived by the owner on Oct 4, 2021. It is now read-only.
Conversation
added 2 commits
July 31, 2015 19:24
IKeyHandler is an interface that allows the current EditMode to say whether or not a key combination is reserved in that context, or whether it can be passed through to the command dispatch
Before passing a key press to the command dispatch, check with the currently focused widget whether or not it is currently overriding the command key mappings for that particular key. This is so that, for example, Escape will still work when an autocomplete popover is visible or the extract method insert point is visible, even if Escape has been assigned to a command
Contributor
|
This lgtm. |
Member
|
It looks ok to me. @mkrueger can you review? |
Contributor
|
I think that shadows a problem somewhere else. It used to work AFAIK. Other than that it'll work that way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the more generic version of #995 where the TextEditor has implemented the IKeyHandler interface, which the command manager then checks to see if the text editor is currently overriding the key press.
Fixes the issues where Escape wouldn't close the Insert Extracted Method overlay, or wouldn't close the autocompletion dialog if it was assigned to a command. (Bug 29887)
It also prevents essential keys from being overridden if they are assigned to a command such as alphanumeric keys or Tab, Return or Backspace.