Handle read access in keyword argument #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jecisc
reviewed
Oct 22, 2025
jecisc
reviewed
Oct 22, 2025
jecisc
reviewed
Oct 22, 2025
jecisc
reviewed
Oct 22, 2025
|
|
||
| (self parent type = #attribute and: [ self parent isInCall ]) ifTrue: [ ^ true ]. | ||
|
|
||
| (self parent type = 'keyword_argument' and: [ self parent _value = self ]) ifTrue: [ ^ true ]. |
Member
There was a problem hiding this comment.
Maybe this should be self isInField: #value ofParentOfType: #keyword_argument?
Try to add a test checking this case:
def function_with_keyword_argument(a, arg1):
pass
variableToAccessInKeywordArgumentCallInParenthesis = 42
function_with_keyword_argument(1, arg1 = (variableToAccessInKeywordArgumentCallInParenthesis))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#37