Conversation
fluffy
approved these changes
May 30, 2026
Collaborator
fluffy
left a comment
fluffy
left a comment
There was a problem hiding this comment.
This looks good. I have two tiny comments that you decide if you want to ignore or not.
| { | ||
| "namespace_tuples": ["example.com"], | ||
| "track_name": "audio", | ||
| "serialized_full_track_name": |
Collaborator
There was a problem hiding this comment.
for all the stuff that is hex encoded, I think it might be good to add _hex to end of name so the json field would be "serialized_full_track_name_hex"
| Each entry tests HKDF-Extract and HKDF-Expand for deriving `moq_key` | ||
| and `moq_salt` from the `track_base_key`. The `track_base_key` values | ||
| are ASCII strings: "sixteen byte key" (16 bytes) for SHA-256 suites and | ||
| "a]256-bit-base-key-for-test!!!!!" (32 bytes) for SHA-512 suites. |
Collaborator
There was a problem hiding this comment.
Did you mean to have the ] in the key - its a bit wierd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.