Skip to content

Impl from fork fast food pocao#327

Merged
ayudaV merged 21 commits intoclass-of-2025from
impl_from_fork_fast_food_poção
Apr 18, 2026

Hidden character warning

The head ref may contain hidden characters: "impl_from_fork_fast_food_po\u00e7\u00e3o"
Merged

Impl from fork fast food pocao#327
ayudaV merged 21 commits intoclass-of-2025from
impl_from_fork_fast_food_poção

Conversation

@ayudaV
Copy link
Copy Markdown
Collaborator

@ayudaV ayudaV commented Feb 19, 2026

No description provided.

@ayudaV ayudaV self-assigned this Feb 19, 2026
@ayudaV ayudaV added Enhancement New feature or request Complete minigame Minigame is ready to be implemented Minigame Implementation Makes modifications to a complete minigame so it can be implemented into Gamutoware Credits info collected Credits info can be found in PRs comments labels Feb 19, 2026
@ayudaV ayudaV changed the title Impl from fork fast food poção Impl from fork fast food pocao Feb 19, 2026
@grandeisa grandeisa self-requested a review February 23, 2026 03:04
Copy link
Copy Markdown
Collaborator

@grandeisa grandeisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementação negada, motivos:

  • Inclui duas pastas de minigame diferentes fast_food_pocao e fast_food_poção
  • Inclui uma pasta com scripts em python implementation_scripts/* que não deveriam estar em um PR de implementação de jogo, caso seja uma adição desejada ao projeto, favor fazer PR próprio e com descrição explicando
  • Alterações fora de escopo em projetoAnaBeatriz (2023S1)

Comment thread implementation_scripts/__init__.py Outdated
Comment thread implementation_scripts/merge_fork_game_folder.py Outdated
Comment thread implementation_scripts/merge_game_contribution.py Outdated
Comment thread .gitignore
Comment thread microjogos/2023S1/projetoAnaBeatriz/cenas/Inimki.gd.uid Outdated
Comment thread microjogos/2023S1/projetoAnaBeatriz/cenas/inimki.gd.uid
Copy link
Copy Markdown
Collaborator

@grandeisa grandeisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Colocar créditos nos sprites das poções ou trocar sprites para assets livres (creditar)
  • Remover assets não utilizados

Comment thread microjogos/2025S1/fast_food_pocao/microgame.tres
@grandeisa grandeisa added Incomplete credits The file credits.gd is missing some info about the game and removed Credits info collected Credits info can be found in PRs comments labels Feb 23, 2026
@ayudaV ayudaV requested a review from grandeisa March 8, 2026 20:14
@ayudaV ayudaV removed the Enhancement New feature or request label Mar 8, 2026
@ayudaV ayudaV removed Complete minigame Minigame is ready to be implemented Incomplete credits The file credits.gd is missing some info about the game labels Mar 8, 2026
@grandeisa grandeisa added this to the Class of 2025 milestone Mar 8, 2026
@grandeisa grandeisa changed the base branch from master to class-of-2025 March 13, 2026 08:35
Comment thread microjogos/2025S1/fast_food_pocao/recursos/imagens/pocao_amarela.png~ Outdated
Comment thread microjogos/2025S1/fast_food_pocao/recursos/sons/perdeu].flac Outdated
@grandeisa grandeisa self-requested a review March 15, 2026 07:43
Copy link
Copy Markdown
Collaborator

@grandeisa grandeisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Microgame doesn't run with error:

Invalid access to property or key 'WIDTH' on a base object of type 'Node2D'.

Possibly a wrong main scene set in the microgame.tres, or maybe the script is missing?

@grandeisa grandeisa added the Bug Something isn't working label Mar 21, 2026
@ayudaV ayudaV requested a review from grandeisa March 21, 2026 19:30
@ayudaV
Copy link
Copy Markdown
Collaborator Author

ayudaV commented Mar 21, 2026

IDK whats happened, but i guess is fixed now

Copy link
Copy Markdown
Collaborator

@grandeisa grandeisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Microgame doesn't launch

Image

@ayudaV ayudaV requested a review from grandeisa April 18, 2026 03:16
@ayudaV
Copy link
Copy Markdown
Collaborator Author

ayudaV commented Apr 18, 2026

for some reason the .tscn ref the right path for gd script but with id of the seu_projeto main.gd

@ayudaV ayudaV removed the Bug Something isn't working label Apr 18, 2026
Copy link
Copy Markdown
Collaborator

@grandeisa grandeisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ayudaV ayudaV requested a review from MateusCitric April 18, 2026 04:28
@ayudaV ayudaV merged commit 659d525 into class-of-2025 Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minigame Implementation Makes modifications to a complete minigame so it can be implemented into Gamutoware

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants