WIP: mqtt stream parser #519
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
With a quick benchmark seems performances have been incresed by ~10% |
robertsLando
requested review from
gnought and
mcollina
and removed request for
gnought
Member
Author
|
@mcollina Could you take a look at this too when you have time ? |
mcollina
requested changes
Jul 7, 2020
Collaborator
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
I think it will slow us down significantly, I'm -1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to implement the work made by @gnought in his https://github.com/gnought/aedes/tree/next branch