Open
Conversation
This commit sets up tsconfigs to avoid type check errors and conflicts between @typed/test and microbundle. It does so by extending a base configuration in for both production and testing environments. The latter prepares the setup for @typed/test v10.0, where a tsconfig can be specified. Signed-off-by: Frederik Krautwald <fkrautwald@gmail.com>
This commit factors out details and adds comments by applying the four-phase testing pattern to increase the readability and understanding of the tests. Signed-off-by: Frederik Krautwald <fkrautwald@gmail.com>
Member
briancavalier
left a comment
briancavalier
left a comment
There was a problem hiding this comment.
Sorry for taking a while to review 😬 Overall, the changes here seem good. I think we need to figure out what to do about lint and format here and in #6. If possible, I'd like to get as close to @most/core, which uses standardjs, as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets up tsconfigs to avoid type check errors and conflicts between @typed/test and microbundle. It does so by extending a base configuration in for both production and testing environments. The latter prepares the setup for @typed/test v10.0, where a tsconfig can be specified. The PR also factors out details and adds comments to tests by applying the four-phase testing pattern to increase the readability and understanding of the tests.