-
Notifications
You must be signed in to change notification settings - Fork 25
Cherry pick MIP-124 (#227) #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Based on [MIP-124](movementlabsxyz/MIP#124). Implements this changes: https://www.notion.so/movementlabs/Staking-reward-using-GGP-28118675b2d780848e30c0c7e51d47cc In the folder `aptos-move/framework/aptos-framework` run `movement move test` to run all test. Or `movement move test -f stake `to run stake related tests. --------- Co-authored-by: musitdev <[email protected]>
movement-migration/framework-upgrades/scripts/feature-flag-reconfig.move
Outdated
Show resolved
Hide resolved
movement-migration/framework-upgrades/scripts/feature-flag-reconfig.move
Show resolved
Hide resolved
|
for testing, can we test if we can upgrade the mainnet mirror with this change? |
|
Upgrade on mainnet mirror successful 🟢 1-aptos-stdlib: 2-aptos-framework 3-aptos-token 4-aptos-token-objects |
|
Many of the tests in delegation_pool are failing, I think it's something simple tho. Checking it out. |
…ure to switch between fee burn/mint and fee transfer to the ggp treasury.
…s-core into cherry-pick-mip-124
|
Regarding this error on mainnet mirror: I attempted using a compiled script instead of CLI with these steps:
And yield this error: Which seems a variant of the same cause. I know now what the error is. It must be the mainnet mirror state not tallying with the framework on the base branch. |
|
GGP Extension Successfully initialized on Mainnet Mirror |
|
Re-generating Move2 upgrade scripts after last commit, await to test mainnet mirror with the new scripts. |
|
Upgrade successful 🟢 |
Based on MIP-124.
Implements these changes:
https://www.notion.so/movementlabs/Staking-reward-using-GGP-28118675b2d780848e30c0c7e51d47cc
In the folder
aptos-move/framework/aptos-frameworkrunaptos move testto run all test.Or
aptos move test -f staketo run stake related tests.See the #227 original PR