Skip to content

Conversation

@musitdev
Copy link

@musitdev musitdev commented Dec 2, 2025

Description

Cherry pick upstream commit: 8b6c5de for bug fix: Add validation for commission percentage in switch_operator.

I've run movement move test.
One test failed (test_update_voting_power_increase_limit_to_more_than_upper_bound_should_fail), but it's not related to the PR. It's linked to the Bo's temporary update.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

…bs#17912)

* Add validation for commission percentage in switch_operator

* fmt
@musitdev musitdev self-assigned this Dec 2, 2025
Copy link
Collaborator

@0xmovses 0xmovses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@musitdev were unit tests for the staking contract ran?

@musitdev
Copy link
Author

musitdev commented Dec 3, 2025

Only one doesn't work because of the patch about the 50% of staking change per epoch. It will run when the patch will be removed. The other test run.
See the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants