chore(release): bump minor rather than major for pre-1.0 breaking changes - #53
Merged
Merged
Conversation
This was referenced Aug 6, 2026
chore(release): bump minor rather than major for pre-1.0 breaking changes
mozilla-ai/otari-sdk-go#25
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR was drafted by Claude via back-and-forth with @njbrake. The reasoning and decisions are his; the prose is Claude's.
Stops release-please proposing
1.0.0. Withbump-minor-pre-major, a breaking change under 1.0.0 bumps the minor instead of the major, so the pending release PR (#51) should recompute from1.0.0to0.3.0.The
1.0.0came fromfix(control-plane)!: map generated errors to typed OtariError(#47), the only!commit since the 0.2.0 tag. Publishing 1.0.0 would signal API stability we are not committing to yet, and the Release workflow publishes to crates.io in the same run as the release PR merge, where the only undo is a yank.Deliberately not setting
bump-patch-for-minor-pre-major:feat:should keep bumping the minor, which is how 0.2.0 was cut.Verified
bump-minor-pre-majoragainst the release-please config schema (ReleaserConfigOptions, "Breaking changes only bump semver minor if version < 1.0.0"), and the full file validates.The same setting is missing from otari-sdk-go, otari-sdk-python, and otari-sdk-ts, which are all pre-1.0 with the same behaviour latent.