Repository navigation
Fix version picker colors on older Android - #51
Merged
Merged
Conversation
We now use HomeAppCard so remove lets remove the old ArchiveGroupCard code so that things are easier to refactor later. Update tests to use VersionSelector directly.
The setTextColor call is available back to Android 10, but to support Android 8 as well this patch overrides the theme for the control.
moztcampbell
added this pull request to stack #54
October 8, 2026 05:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'setTextColor' call was guarded to API 36 even though it seems to work fine in Android 10. Since we need to still support Android 8, I also used a theme override. This fixes #48
Stack created with GitHub Stacks CLI • Give Feedback 💬