Exclude theme review from anything policy-review-selection related#25147
Merged
eviljeff merged 1 commit intoJul 17, 2026
Conversation
eviljeff
marked this pull request as ready for review
July 15, 2026 12:53
eviljeff
requested review from
a team and
chrstinalin
and removed request for
a team
July 15, 2026 12:53
chrstinalin
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#16321
Description
Makes approve and reject reviewer actions available to theme review again, by making a blanket exclusion of policy review selection actions for themes.
Context
Previously we had a(n increasingly complicated) set of criteria for determining if a reviewer action should be available when
enable-policy-review-selectionwas enabled, and was disabled. Themes were supposed to be excluded from the changes, but one of the patches introduced a regression.Theme review will eventually switch over to use policy-review-selection too, but not at launch (and some issues like mozilla/addons#16261 need to be done too)
Testing
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.