Conversation
If you set the [autowebcompat:reproduce]` flag on a bug, re-run the reproduction. This is useful in case we improved hackbot to be able to try in more cases, or if the old reproduction was against a previous version of the site and so is not longer valid.
6cfcc78 to
db97cf1
Compare
| require_user_story = {} | ||
|
|
||
| remove_whiteboard(bug, bug_update, [self.whiteboard_progress_token]) | ||
|
|
There was a problem hiding this comment.
I think we might need to check and clear previously set tokens, right? i.e. if a run has failed before with [autowebcompat:repro-failed] and new one succeeded , [autowebcompat:repro-failed] needs to be removed.
Also for user story, if a new run will update autowebcompat-repro-status to success, but autowebcompat-repro-reason will still stay from the previous run (I think diagnosis request does that).
There was a problem hiding this comment.
Ah, good catch.
I've done a bit of a refactor to make the BugUpdate class a bit easier to use, and I've added a list of user story fields to each class and set things up to start by setting them to None so that they're removed, and then updating them in the method with new values where appropriate.
It's still a bit ugly in that we end up sharing logic between the classes, but I think it's a step on a way to a better solution.
This refactors the BugUpdate class so that bug modifications go through methods that update the internal state rather than updating the state directly. The final state to be passed to bugzilla is then created by calling get_updates() on the class.
…tory Give each Task an ordered set of user story fields that it owns, and at the start of the bug update, set these user story fields to None in BugUpdate, so that they're removed if no new value is provided to overwrite them.
2 participants
If you set the [autowebcompat:reproduce]` flag on a bug, re-run the reproduction. This is useful in case we improved hackbot to be able to try in more cases, or if the old reproduction was against a previous version of the site and so is not longer valid.
Checklist for reviewer:
Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title)
Scan the PR and verify that no changes (particularly to
.circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logsEnsure the container image will be using permissions granted to telemetry-airflow responsibly.