-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Add setter for some FontFaceObject properties #20427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Aditi-1400 here's a test file: |
@calixteman This one's also pretty close to ~10MB 😅 |
Oh, sorry I obviously didn't check the size. |
e76fa29 to
dcfaea0
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7259cb55e9be09e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0dc2e410e311318/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7259cb55e9be09e/output.txt Total script time: 39.77 mins
Image differences available at: http://54.241.84.105:8877/7259cb55e9be09e/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0dc2e410e311318/output.txt Total script time: 76.18 mins
Image differences available at: http://54.193.163.58:8877/0dc2e410e311318/reftest-analyzer.html#web=eq.log |
dcfaea0 to
7743d11
Compare
|
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a0c10634f00d331/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a0c10634f00d331/output.txt Total script time: 39.48 mins
Image differences available at: http://54.241.84.105:8877/a0c10634f00d331/reftest-analyzer.html#web=eq.log |
calixteman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
This fixes #20426 which was caused as a regression of #20197.
From https://bugzilla.mozilla.org/show_bug.cgi?id=1998618#c2:
For now, this makes the properties
disableFontFaceandbboxmutable as they are later reassgined in https://github.com/mozilla/pdf.js/blob/master/src/core/evaluator.js#L4742 while falling back to browser fonts and in https://github.com/mozilla/pdf.js/blob/master/src/core/evaluator.js#L4830.