Change the sidebar for a views manager #20495
Conversation
l10n/en-US/viewer.ftl
Outdated
| pdfjs-views-manager-status-waiting-ready-label = Getting your file ready… | ||
| pdfjs-views-manager-status-waiting-uploading-label = Uploading file… | ||
| pdfjs-views-manager-current-outline-item-button = | ||
| .title = Find Current Outline Item |
There was a problem hiding this comment.
It's an entry in the document outline.
In most of the documents I saw the outline is almost a table of contents but according to the pdf terminology an outline item is sometimes called bookmarks (it's from the specs). In Acrobat Reader the panel dedicated to document outline is labelled "Bookmarks".
Anyway this string was already existing and I just changed its name (see https://searchfox.org/firefox-main/source/toolkit/locales/en-US/toolkit/pdfviewer/viewer.ftl#201).
That said when I see the current translation in french (which is really bad, tbh I don't understand what it means), we need to have some help from the content team about that.
calixteman
force-pushed
the
new_sidebar
branch
2 times, most recently
from
97fee23 to
86b3dbf
Compare
l10n/en-US/viewer.ftl
Outdated
| pdfjs-views-manager-pages-status-waiting-ready-label = Getting your file ready… | ||
| pdfjs-views-manager-pages-status-waiting-uploading-label = Uploading file… | ||
| ## For now keep the previous translations in waiting for some new strings or |
There was a problem hiding this comment.
This is not really useful for localizers, they will translate it as well as they can.
When we change the strings, we will need new IDs. If we only add comments, it will be too late.
There was a problem hiding this comment.
Ok so for now I can just keep the old ids and strings.
And once we've something from the content team, I'll make a follow-up. Does that sound good ?
There was a problem hiding this comment.
Yep, that's probably the best for localizers.
calixteman
force-pushed
the
new_sidebar
branch
from
86b3dbf to
5b231f7
Compare
calixteman
force-pushed
the
new_sidebar
branch
from
5b231f7 to
e250fad
Compare
Update the styles and HTML to reflect the new views manager concept. For now, nothing about split/merge functionality is implemented or visible. The new styles for the outline, attachments, and layers will be added later. The thumbnail view is now accessible with the keyboard.
calixteman
force-pushed
the
new_sidebar
branch
from
e250fad to
e023ab9
Compare
2 participants
Update the styles and HTML to reflect the new views manager concept. For now, nothing about split/merge functionality is implemented or visible. The new styles for the outline, attachments, and layers will be added later.
The thumbnail view is now accessible with the keyboard.