Skip to content

feat: Add Faraday 2.x support #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sahil-brodiya-mrsool wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: Add Faraday 2.x support #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c857500
feat: Add Faraday 2.x support
sahil-brodiya-mrsool Dec 12, 2025
2f40856
fix: Add required_ruby_version and improve git ls-files compatibility
sahil-brodiya-mrsool Dec 12, 2025
516002c
fix: Replace git ls-files with Dir.glob for bundler compatibility
sahil-brodiya-mrsool Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/zerobounce/configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# frozen_string_literal: true

require 'faraday'
require 'faraday_middleware'
require 'zerobounce/middleware/raise_error'

module Zerobounce
Expand Down Expand Up @@ -48,7 +47,7 @@ def initialize
builder.response(:json, content_type: /\bjson$/, parser_options: { symbolize_names: true })
builder.response(:logger) { |l| l.filter(/(api_?key=)(\w+)/, '\1[REMOVED]') } if ENV['ZEROBOUNCE_API_DEBUG']
builder.use(Zerobounce::Middleware::RaiseError)
builder.adapter(Faraday.default_adapter)
builder.adapter(:net_http)
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions spec/zerobounce/configuration_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
expect(builder).to have_received(:use).with(Zerobounce::Middleware::RaiseError)
end

it 'uses Faraday default adapter' do
it 'uses net_http adapter' do
described_class.new.middleware.call(builder)
expect(builder).to have_received(:adapter).with(Faraday.default_adapter)
expect(builder).to have_received(:adapter).with(:net_http)
end
end
end
10 changes: 5 additions & 5 deletions zerobounce.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,18 @@ Gem::Specification.new do |spec| # rubocop:disable Metrics/BlockLength
spec.description = 'A Ruby client for Zerobounce.net.'
spec.homepage = 'https://github.com/afrase/zerobounce'
spec.license = 'MIT'
spec.required_ruby_version = '>= 2.5.0'

spec.files = `git ls-files -z`.split("\x0").reject do |f|
f.match(%r{^(test|spec|features)/})
end
spec.files = Dir.glob('{lib,exe}/**/*', File::FNM_DOTMATCH).reject do |f|
File.directory?(f) || f.match(%r{^(test|spec|features)/})
end + %w[README.md LICENSE.txt CHANGELOG.md].select { |f| File.exist?(f) }
spec.bindir = 'exe'
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ['lib']

spec.metadata['yard.run'] = 'yri' # use "yard" to build full HTML docs.

spec.add_dependency 'faraday', '>= 0.14', '< 2.0'
spec.add_dependency 'faraday_middleware', '>= 0.12', '< 2.0'
spec.add_dependency 'faraday', '>= 0.14', '< 3.0'

spec.add_development_dependency 'bundler', '~> 1.16'
spec.add_development_dependency 'pry', '~> 0.13.0'
Expand Down