fix(originality): include gis and security in check-agent-originality.sh AGENT_DIRS#649
Closed
Synvoya wants to merge 1 commit into
Closed
fix(originality): include gis and security in check-agent-originality.sh AGENT_DIRS#649Synvoya wants to merge 1 commit into
Synvoya wants to merge 1 commit into
Conversation
check-agent-originality.sh's AGENT_DIRS omitted the gis and security divisions (and listed the non-division strategy/, which has no agent frontmatter), so those divisions' agents were silently never checked for near-duplicates. Align the list to the canonical 16 divisions (matches scripts/lint-agents.sh); refresh the calibration note (corpus 184->233 agents, worst pair ~1.9%).
Owner
|
Thanks for catching the drift here — you're right that Closing this as superseded by #659, which fixes the root cause: instead of patching the hardcoded list, #659 has the script read |
msitarzewski
added a commit
that referenced
this pull request
Jul 5, 2026
check-agent-originality.sh hardcoded its own copy of the division list (AGENT_DIRS) in the Python heredoc — a 5th copy that check-divisions.sh's bash-array parser never saw, so it drifted: it was missing `gis` and `security` and still carried the retired `strategy`. The practical effect was that every gis/ and security/ agent — including newly added ones — skipped the duplicate-detection scan entirely. Read divisions.json directly instead of hardcoding, so this check can never drift from the catalog again. Now scans all 16 divisions; verified green in full-audit mode. Supersedes #649/#650, which patch the hardcoded constants rather than removing them. Claude-Session: https://claude.ai/code/session_01WKnDRWM4izsB8WAXKszhsq Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
scripts/check-agent-originality.shbuilds its comparison corpus from a hardcodedAGENT_DIRSlist that had drifted out of sync with the canonical division set indivisions.json. It was missinggisandsecurity, and it listed the non-divisionstrategy/(which has no agent frontmatter). As a result, every agent in thegisandsecuritydivisions was silently never checked for near-duplicates.This aligns
AGENT_DIRSto the canonical 16 divisions (matchingscripts/lint-agents.sh), and refreshes the now-stale calibration note in the same file.Testing
scripts/check-agent-originality.shwith no args) now covers 233 agents, including 23 gis/security agents that were previously excluded — exit 0, worst same-pair similarity ~1.9% (well under the WARN/FAIL thresholds). Updated the header/output baseline from the stale184 agents / ~1.5%to233 / ~1.9%accordingly.bash -n scripts/check-agent-originality.shclean.Notes
This touches a CI/tooling script — happy to move it to an Issue/Discussion first if you'd prefer that per CONTRIBUTING. There is a small follow-up (guarding this list in
check-divisions.shso it can't drift again) which I've opened as a separate, stacked PR.