Repository navigation
fix(gallery): place context options at the root - #12590
Merged
Merged
Conversation
The Qwen3 template nests context_size, f16, and mmap under parameters, where the typed model configuration ignores them. Move these options to the root and correct three model-specific context overrides. Test the real gallery data and generated qwen3-vl-4b-thinking YAML. Document manual repair because template updates do not rewrite installed configurations. Fixes #12528 Assisted-by: nib:gpt-6-astra Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #12528.
Gallery installation of
qwen3-vl-4b-thinkingusesgallery/qwen3.yaml. That template placedcontext_size,f16, andmmapunderparameters. The installer preserved that nesting, but the model loader ignored those fields and applied the global context default.Related: #12529 documents placement and precedence; this PR fixes the gallery producer. No runtime precedence changes or automatic migration are included.
Notes for Reviewers
The new regression tests failed with three intended placement failures before the data corrections. After the fix, 41 selected specs and the standard package tests passed. The verification command was independently rerun successfully:
git diff --checkpassed. Independent code review found no blockers. The installation regression uses placeholder weight files and does not download models.Full builds, the complete test suite, and hardware inference were not run. Activating the existing explicit context values can change KV-cache memory use. Moving
mmap: trueto the root also makes that declared setting effective; Intel hardware behavior was not tested.Signed commits