Repository navigation
fix(ui): repair model import advanced controls - #12599
Merged
Merged
Conversation
Place advanced options before checks and focus them from Adjust. Use the shared kit busy spinner without a second loading indicator. Clarify that source recognition checks format, not model contents. Cover pending submissions, keyboard disclosure, backend preferences, and source copy with full-page browser regressions. Assisted-by: Codex:gpt-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move Advanced options directly below the request preview. Adjust now opens, focuses, and scrolls to the controls. Keep automatic backend selection as the default and preserve explicit backend preferences.
Remove duplicate loading spinners from Import and YAML Save. Clarify that source-format recognition does not validate model contents.
Notes for Reviewers
Regression tests failed against the original implementation before passing with the fix. Independently verified:
To reproduce from core/http/react-ui, with the existing E2E server configuration:
PLAYWRIGHT_EXTERNAL_SERVER=1 PW_WORKERS=2 npm run test:e2e -- "e2e/import-.*spec.js" node --test src/utils/tools.test.js npx eslint src/pages/ImportModel.jsx e2e/import-controls.spec.js e2e/import-flow.spec.js npm run lint:inline-styles npm run buildBrowser tests mock imports; no models were downloaded. Full repository tests and make build were not run. Copy changes cover English only.
Signed commits