Skip to content

[code-infra] Fix flaky PreferencesMenu test #20315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bernardobelchior wants to merge 5 commits into from
Closed

[code-infra] Fix flaky PreferencesMenu test #20315

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd13a39
[code-infra] Use fake timers in PreferencesMenu test
bernardobelchior Nov 13, 2025
261451c
Use a normal wait instead
bernardobelchior Nov 13, 2025
b5b6cd5
use sleep
JCQuintas Nov 14, 2025
e914178
Merge branch 'master' into use-fake-timers-preference-menu-test
JCQuintas Nov 14, 2025
afdf088
revert
JCQuintas Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...heduler/src/internals/components/header-toolbar/preferences-menu/PreferencesMenu.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { createSchedulerRenderer, SchedulerStoreRunner } from 'test/utils/schedu
import { EventCalendarProvider } from '@mui/x-scheduler-headless/event-calendar-provider';
import { screen } from '@mui/internal-test-utils';
import { EventCalendarStoreContext } from '@mui/x-scheduler-headless/use-event-calendar-store-context';
import { afterAll } from 'vitest';
import { PreferencesMenu } from './PreferencesMenu';
import { getPreferencesMenu, openPreferencesMenu } from '../../../utils/test-utils';

Expand All @@ -11,6 +12,12 @@ describe('<PreferencesMenu />', () => {

const { render } = createSchedulerRenderer();

afterAll(async () => {
await new Promise((resolve) => {
setTimeout(resolve);
});
Comment on lines +16 to +18
Copy link
Contributor

@romgrk romgrk Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a sleep(0) function in test/utils/helperFn.

});

it('should render the menu when no config is provided', async () => {
render(
<EventCalendarProvider events={[]}>
Expand Down
Loading