[pickers] Do not loose slotProps.field.slotProps
#20322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
type: regression
|
Deploy preview: https://deploy-preview-20322--material-ui-x.netlify.app/ Bundle size report
|
flaviendelangle
commented
Nov 14, 2025
| /> | ||
| <DateRangePicker | ||
| slotProps={{ separator: { sx: { opacity: 0.5 } } } as any} | ||
| slotProps={{ |
| {...fieldProps} | ||
| slots={slots} | ||
| slotProps={slotProps} | ||
| slots={{ ...slots, ...(fieldProps as any).slots }} |
Member
Author
There was a problem hiding this comment.
I'm not doing deep merge, people can't define slots or slotProps with both approach.
But I think that is more than fine, we are just trying to fix one specific scenario which is the multi-input specific slots, that the picker is not aware of 👍
Member
There was a problem hiding this comment.
Wondering why useSlotProps doesn't return the correct type of fieldProps.
Member
Author
There was a problem hiding this comment.
Do it doesn't 😢
fieldProps.slots is not defined
MBilalShafi
approved these changes
Nov 19, 2025
| {...fieldProps} | ||
| slots={slots} | ||
| slotProps={slotProps} | ||
| slots={{ ...slots, ...(fieldProps as any).slots }} |
Member
There was a problem hiding this comment.
Wondering why useSlotProps doesn't return the correct type of fieldProps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #20293
I think this was broken during the latest refactoring of the slots propagation.
We do need
slotProps.field.slotPropsto work (same forslotProps.field.slots)