Skip to content

[scheduler] Fix flaky PreferencesMenu test #20331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 17, 2025
Merged

[scheduler] Fix flaky PreferencesMenu test #20331

merged 3 commits into from
Nov 17, 2025

Conversation

@bernardobelchior
Copy link
Member

@bernardobelchior bernardobelchior commented Nov 14, 2025 •
edited
Loading

Fixes PreferencesMenu flaky test by patching Base UI's useScrollLock.

The fix was merged upstream (mui/base-ui#3218), but there are many breaking changes, so this is meant as a short-term fix. When the scheduler team upgrades Base UI to 1.0.0-beta.5 this patch can be removed.

Runs (to ensure it's actually fixed):

  1. #1
  2. #2
  3. #3

@bernardobelchior bernardobelchior added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: scheduler Changes related to the scheduler. labels Nov 14, 2025
@mui-bot
Copy link

mui-bot commented Nov 14, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-20331--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 90eda49

@bernardobelchior bernardobelchior force-pushed the patch-base-ui-scroll-lock branch 2 times, most recently from c40dbb4 to 0433dd3 Compare November 17, 2025 11:14
@bernardobelchior bernardobelchior force-pushed the patch-base-ui-scroll-lock branch from 0433dd3 to 90eda49 Compare November 17, 2025 12:36
@bernardobelchior bernardobelchior marked this pull request as ready for review November 17, 2025 12:55
@bernardobelchior bernardobelchior changed the title [scheduler] Fix PreferencesMenu flaky test [scheduler] Fix flaky PreferencesMenu test Nov 17, 2025
@bernardobelchior bernardobelchior requested a review from a team November 17, 2025 15:36
flaviendelangle
flaviendelangle approved these changes Nov 17, 2025
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick and efficient 😆

@bernardobelchior bernardobelchior merged commit a1556e8 into mui:master Nov 17, 2025
21 checks passed
@bernardobelchior bernardobelchior deleted the patch-base-ui-scroll-lock branch November 17, 2025 17:04
@bernardobelchior bernardobelchior mentioned this pull request Nov 18, 2025
Merged
bernardobelchior added a commit to bernardobelchior/mui-x that referenced this pull request Nov 19, 2025
@bernardobelchior
Revert "[scheduler] Fix flaky PreferencesMenu test (mui#20331)"
62bae2f 
This reverts commit a1556e8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees

No one assigned

Labels

scope: scheduler Changes related to the scheduler. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bernardobelchior @mui-bot @flaviendelangle