Skip to content

Comments

v1.6.0: Merge feat/next into main#256

Merged
popenta merged 77 commits intomainfrom
feat/next
Jun 12, 2025
Merged

v1.6.0: Merge feat/next into main#256
popenta merged 77 commits intomainfrom
feat/next

Conversation

@popenta
Copy link
Collaborator

@popenta popenta commented Jun 12, 2025

No description provided.

popenta and others added 30 commits April 14, 2025 15:22
@popenta popenta self-assigned this Jun 12, 2025
@popenta popenta added the ignore-for-release-notes Ignore for release notes label Jun 12, 2025
@andreibancioiu andreibancioiu requested a review from Copilot June 12, 2025 08:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges the feat/next branch into main for version v1.6.0 and introduces new governance and multisig functionality as well as several enhancements across tests, configuration, and documentation.

  • Added comprehensive test cases for GovernanceController functionality
  • Introduced governance controller methods with transaction creation for proposals, votes, and fee claims
  • Updated entrypoints, constants, and workflows to support governance and multisig features

Reviewed Changes

Copilot reviewed 50 out of 50 changed files in this pull request and generated no comments.

Show a summary per file
File Description
multiversx_sdk/governance/governance_controller_test.py Adds tests to validate new governance controller transactions such as proposals, voting, closing proposals, and configuration changes
multiversx_sdk/governance/governance_controller.py Implements methods for creating governance-related transactions and querying configuration, proposals, and voting power
multiversx_sdk/governance/init.py Exports governance-related classes and resources
multiversx_sdk/entrypoints/entrypoints.py Adds factory methods for creating multisig and governance controllers and their transactions
multiversx_sdk/core/transactions_factory_config.py Adds new gas limit constants for governance operations
multiversx_sdk/core/proto/transaction_pb2.pyi / transaction_pb2.py Updates type hints and source descriptor for protocol buffers
multiversx_sdk/core/constants.py Introduces the governance smart contract address constant
multiversx_sdk/account_management/account_controller.py Adjusts the factory initialization and removes the guardian options setting from account transactions
multiversx_sdk/abi/variadic_values.py
multiversx_sdk/abi/code_metadata_value.py
Improves type annotations and expands payload handling
multiversx_sdk/init.py
docs/*.rst
README.md
Updates package exports and documentation to include new governance and multisig modules
.github/workflows/*.yml Sets read permissions for CI workflows
Comments suppressed due to low confidence (1)

multiversx_sdk/account_management/account_controller.py:81

  • The removal of the guardian setting for the transaction differs from other controllers. Please confirm that this omission is intentional and that account transactions do not require guardian configuration.
-        self._set_version_and_options_for_guardian(transaction)

@github-actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  multiversx_sdk/abi
  bigint_value.py
  bool_value.py
  code_metadata_value.py
  interface.py
  option_value.py
  small_int_values.py
  multiversx_sdk/account_management
  account_controller.py 14
  multiversx_sdk/core
  errors.py
  interfaces.py
  transaction.py
  transaction_computer.py
  multiversx_sdk/entrypoints
  entrypoints.py 191, 194, 197, 200
  multiversx_sdk/governance
  governance_controller.py 43, 48, 94, 97-98, 126, 129-130, 157, 160-161, 322-335
  governance_transactions_outcome_parser.py 115-118
  multiversx_sdk/multisig
  multisig_controller.py 50, 55, 114, 117-118, 598, 962, 965-966, 969, 972-973, 1117
  multisig_transactions_factory.py 223, 273, 284, 312, 348-361, 415, 478
  multisig_transactions_outcome_parser.py 24-27, 30-33, 36-38
  resources.py 21-24, 78, 85, 88, 91
  multiversx_sdk/network_providers
  api_network_provider.py
  interface.py
  proxy_network_provider.py
  resources.py
  transaction_awaiter.py
  multiversx_sdk/testutils
  mock_network_provider.py
  multiversx_sdk/wallet
  user_keys.py 80-81
Project Total  

The report is truncated to 25 files out of 71. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

@popenta popenta merged commit 91bfedf into main Jun 12, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants