Conversation
Merge main in feat/next
Generate proto files
Multisig transactions factory
Fix Cookbook examples
Fix duplication of user agent
Governance transactions factory
Rename parameter to match other parameters
Governance controller
Governance fixes
Update cryptography to 44.0.1
Small fixes and extra checks
Governance and Multisig examples
Merge main in feat/next
miiu96
approved these changes
Jun 12, 2025
andreibancioiu
approved these changes
Jun 12, 2025
danielailie
approved these changes
Jun 12, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR merges the feat/next branch into main for version v1.6.0 and introduces new governance and multisig functionality as well as several enhancements across tests, configuration, and documentation.
- Added comprehensive test cases for GovernanceController functionality
- Introduced governance controller methods with transaction creation for proposals, votes, and fee claims
- Updated entrypoints, constants, and workflows to support governance and multisig features
Reviewed Changes
Copilot reviewed 50 out of 50 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| multiversx_sdk/governance/governance_controller_test.py | Adds tests to validate new governance controller transactions such as proposals, voting, closing proposals, and configuration changes |
| multiversx_sdk/governance/governance_controller.py | Implements methods for creating governance-related transactions and querying configuration, proposals, and voting power |
| multiversx_sdk/governance/init.py | Exports governance-related classes and resources |
| multiversx_sdk/entrypoints/entrypoints.py | Adds factory methods for creating multisig and governance controllers and their transactions |
| multiversx_sdk/core/transactions_factory_config.py | Adds new gas limit constants for governance operations |
| multiversx_sdk/core/proto/transaction_pb2.pyi / transaction_pb2.py | Updates type hints and source descriptor for protocol buffers |
| multiversx_sdk/core/constants.py | Introduces the governance smart contract address constant |
| multiversx_sdk/account_management/account_controller.py | Adjusts the factory initialization and removes the guardian options setting from account transactions |
| multiversx_sdk/abi/variadic_values.py multiversx_sdk/abi/code_metadata_value.py |
Improves type annotations and expands payload handling |
| multiversx_sdk/init.py docs/*.rst README.md |
Updates package exports and documentation to include new governance and multisig modules |
| .github/workflows/*.yml | Sets read permissions for CI workflows |
Comments suppressed due to low confidence (1)
multiversx_sdk/account_management/account_controller.py:81
- The removal of the guardian setting for the transaction differs from other controllers. Please confirm that this omission is intentional and that account transactions do not require guardian configuration.
- self._set_version_and_options_for_guardian(transaction)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.