Skip to content

Comments

Allow setting awaiting options for controller methods#289

Merged
popenta merged 2 commits intomainfrom
add-awaiting-options-for-controllers
Feb 10, 2026
Merged

Allow setting awaiting options for controller methods#289
popenta merged 2 commits intomainfrom
add-awaiting-options-for-controllers

Conversation

@popenta
Copy link
Collaborator

@popenta popenta commented Feb 10, 2026

No description provided.

@popenta popenta self-assigned this Feb 10, 2026
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  multiversx_sdk/abi
  bigint_value.py
  bool_value.py
  code_metadata_value.py
  interface.py
  option_value.py
  optional_value.py
  small_int_values.py
  multiversx_sdk/core
  address.py
  errors.py
  interfaces.py
  transaction.py
  transaction_computer.py
  multiversx_sdk/delegation
  delegation_controller.py 84, 91-92, 483, 490-491, 519, 526-527, 555, 562-563, 594, 601-602
  multiversx_sdk/entrypoints
  entrypoints.py 151
  multiversx_sdk/governance
  governance_controller.py 101, 108-109, 137, 144-145, 172, 179-180
  multiversx_sdk/multisig
  multisig_controller.py 119, 126-127, 971, 978-979, 982, 989-990
  multiversx_sdk/network_providers
  api_network_provider.py
  errors.py
  interface.py
  proxy_network_provider.py
  resources.py
  transaction_awaiter.py
  multiversx_sdk/smart_contracts
  smart_contract_controller.py 195, 202-203
  multiversx_sdk/testutils
  mock_network_provider.py
  multiversx_sdk/token_management
  token_management_controller.py 107, 114-115, 160, 167-168, 213, 220-221, 268, 275-276, 313, 320-321, 349, 356-357, 385, 392-393, 432, 439-440, 525, 532-533, 617, 624-625, 712, 719-720, 807, 814-815, 843, 850-851, 879, 886-887, 916, 923-924, 953, 960-961, 990, 997-998, 1029, 1036-1037, 1068, 1075-1076, 1109, 1116-1117, 1150, 1157-1158, 1191, 1198-1199, 1232, 1239-1240, 1273, 1280-1281, 1310, 1317-1318, 1359, 1366-1367, 1408, 1415-1416, 1448, 1455-1456, 1482, 1489, 1526, 1533-1534, 1571, 1578-1579
Project Total  

The report is truncated to 25 files out of 70. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

Base automatically changed from supernova-changes to main February 10, 2026 10:58
@AdoAdoAdo AdoAdoAdo requested a review from Copilot February 10, 2026 11:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the SDK controllers’ “await completed” convenience methods to accept and forward AwaitingOptions, enabling callers to configure polling/timeout behavior when waiting for transactions to complete.

Changes:

  • Added an optional options: Optional[AwaitingOptions] = None parameter to controller await_completed_* methods and forwarded it to await_transaction_completed().
  • Updated NetworkEntrypoint.await_transaction_completed() to accept and forward AwaitingOptions.
  • Reformatted the delegation controller’s local INetworkProvider protocol signature for readability.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
multiversx_sdk/token_management/token_management_controller.py Adds AwaitingOptions passthrough to token-management await_completed_* methods.
multiversx_sdk/smart_contracts/smart_contract_controller.py Adds AwaitingOptions passthrough to await_completed_deploy/execute.
multiversx_sdk/multisig/multisig_controller.py Adds AwaitingOptions passthrough to multisig await helpers.
multiversx_sdk/governance/governance_controller.py Adds AwaitingOptions passthrough to governance await helpers.
multiversx_sdk/entrypoints/entrypoints.py Exposes AwaitingOptions on the entrypoint’s await_transaction_completed().
multiversx_sdk/delegation/delegation_controller.py Adds AwaitingOptions passthrough to delegation await helpers and formats protocol signature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@popenta popenta merged commit 3f9b2c7 into main Feb 10, 2026
8 of 9 checks passed
@popenta popenta deleted the add-awaiting-options-for-controllers branch February 10, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants