[Waste] Always have quarter/three-quarter image/collections even on mobile #5730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image can always be put inline with the collection dates, and we can make the services full width until a wider point. [Bexley] Fixes issue with missing margins on garden waste entry.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5730 +/- ##
=======================================
Coverage 82.59% 82.59%
=======================================
Files 455 455
Lines 35401 35401
Branches 5751 5751
=======================================
Hits 29240 29240
Misses 4480 4480
Partials 1681 1681 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will need to run make_css. I don't think this should have any bad effects. Basically makes the quarter/three-quarter view always happen at any width rather than only >40em; and moves the services.html template down to a new row that is full width until $large-screen width when it becomes three-quarters like what's above. Also removed some inline styling that didn't seem needed; might be some tidying that could be done, but generally seems okay? [skip changelog]
Quick comparison before/after:
