feat(api): make ApiClient public and add Store::local for custom backends - #259
Open
hboisgibault wants to merge 2 commits into
Open
feat(api): make ApiClient public and add Store::local for custom backends#259hboisgibault wants to merge 2 commits into
hboisgibault wants to merge 2 commits into
Conversation
Make ApiClient public and add Store::local so external crates can implement custom store backends (e.g. OPFS in the browser) by serving proto::Request on a local channel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Storewas only constructible from in-crate backends (MemStore,FsStore) or viaStore::connect(remote). External crates could not back aStorewith a custom implementation (e.g. OPFS in the browser/WASM, in-memory test backend) by servingproto::Requeston a localirpcchannel, becauseApiClientand the local constructor werepub(crate).Changes
ApiClient(irpc::Client<proto::Request>) public.Store::local(client: ApiClient)public constructor: create aStorefrom a custom local rpc client.Store::from_senderaspub(crate)thin wrapper overStore::local(no breaking change).Example