Fix compilation and update Windows build instructions#241
Open
woot000 wants to merge 2 commits inton64dev:masterfrom
Open
Fix compilation and update Windows build instructions#241woot000 wants to merge 2 commits inton64dev:masterfrom
woot000 wants to merge 2 commits inton64dev:masterfrom
Conversation
Primarily -Wincompatible-pointer-type errors and a couple miscellaneous errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix compilation for both gcc and clang (mostly -Wincompatible-pointer-type errors). Tested compilation with MSYS2 CLANG64 (clang) and UCRT64 (gcc) on Windows 11 and CachyOS 6.19.11 (gcc) and each target successfully compiled an executable and ran.
I also updated the build instructions for Windows, because I don't think installing 15 year old MSYS 1.0.11 and manually copying and extracting five compressed files is the easiest way to build CEN64 on Windows. My method does exclude Windows XP compatibility, though I'm not sure any machine running Windows XP with era-appropriate hardware would get even close to running at full speed