Fix: continueOnFail error management #88
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I observed some weird behaviors when testing a custom node which was used with `continueOnFail()`, and would return the items, as is done in this example. ## Issues: - Records are being pushed in the `items` array within a loop over them, this essentially causes an infinite loop. I fixed that loop by adding `itemCount` - Upon fixing the infinite loop, I noticed both `success` and `error` branches of the node would activate, that was because the pushed item had an `error` field (which triggers the error branch), but the original item was still present without an error field (which trigger the success branch) There may be better fixes to this, but this approach worked for me.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed some weird behaviors when testing a custom node which was used with
continueOnFail(), and would return the items, as is done in this example.Issues:
itemsarray within a loop over them, this essentially causes an infinite loop. I fixed that loop by addingitemCountsuccessanderrorbranches of the node would activate, that was because the pushed item had anerrorfield (which triggers the error branch), but the original item was still present without an error field (which trigger the success branch)I've managed to get a proper working behaviour with this change. There may be better fixes to this, but this approach worked for me.