feat: Binary data inside json #21711
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add-binarydata-component-for-binaries-included-in-json-schema-view
michael-radency
added
ui
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 5. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
BundleMonUnchanged files (2)
No change in files bundle size Groups updated (2)
Final result: ✅ View report in BundleMon website ➡️ |
❌ 14 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 6 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="packages/frontend/editor-ui/src/app/composables/useDataSchema.ts">
<violation number="1" location="packages/frontend/editor-ui/src/app/composables/useDataSchema.ts:69">
Rule violated: **Prefer Typeguards over Type casting**
Avoid asserting `input` to this shape with `as`; per the “Prefer Typeguards over Type casting” rule, refine `isBinary` (or introduce a dedicated type guard) so these properties are available without a cast.</violation>
<violation number="2" location="packages/frontend/editor-ui/src/app/composables/useDataSchema.ts:76">
`join('.')` coerces missing binary metadata to literal "undefined", so binary items with no fileName/fileExtension surface as `undefined.undefined`. Filter out absent parts before joining to avoid the regression.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
packages/frontend/editor-ui/src/app/composables/useDataSchema.ts
Outdated
Show resolved
Hide resolved
packages/frontend/editor-ui/src/app/composables/useDataSchema.ts
Outdated
Show resolved
Hide resolved
…add-binarydata-component-for-binaries-included-in-json-schema-view
…add-binarydata-component-for-binaries-included-in-json-schema-view
This comment has been minimized.
This comment has been minimized.
node-3854-add-binarydata-component-for-binaries-included-in-json-schema-view
…add-binarydata-component-for-binaries-included-in-json-schema-view
…add-binarydata-component-for-binaries-included-in-json-schema-view
…add-binarydata-component-for-binaries-included-in-json-schema-view
…add-binarydata-component-for-binaries-included-in-json-schema-view
…add-binarydata-component-for-binaries-included-in-json-schema-view
… on default filesystem, binary data access by property fixes
…add-binarydata-component-for-binaries-included-in-json-schema-view
…add-binarydata-component-for-binaries-included-in-json-schema-view
…add-binarydata-component-for-binaries-included-in-json-schema-view
…add-binarydata-component-for-binaries-included-in-json-schema-view
…add-binarydata-component-for-binaries-included-in-json-schema-view
…add-binarydata-component-for-binaries-included-in-json-schema-view
|
Found 14 test failures on Blacksmith runners: Failures
|
…add-binarydata-component-for-binaries-included-in-json-schema-view
|
E2E Tests: n8n tests passed after 8m 56.4s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
…add-binarydata-component-for-binaries-included-in-json-schema-view
…add-binarydata-component-for-binaries-included-in-json-schema-view
…add-binarydata-component-for-binaries-included-in-json-schema-view
…add-binarydata-component-for-binaries-included-in-json-schema-view
…add-binarydata-component-for-binaries-included-in-json-schema-view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new combined binary mode
Adds a way to download and preview the binary data included in json from Schema or Table views
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)