ADK Azure AI Starter #115
ADK Azure AI Starter #115
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| @@ -0,0 +1 @@ | |||
| {"instaceID":"232322a0-e526-489c-8e1f-73123a505dea"} No newline at end of file | |||
There was a problem hiding this comment.
Bug: Environment Files: Prevent Developer Workflow Conflicts.
The AzuriteConfig file is an Azurite storage emulator runtime file that's auto-generated during local development. These files are environment-specific and commonly added to .gitignore since they can cause conflicts between developers and contain local configuration that differs per machine.
| @@ -0,0 +1 @@ | |||
| {"filename":"/Users/vandenbusch/Library/CloudStorage/[email protected]/Geteilte Ablagen/VDB Solutions GmbH /GitHub_2025/self-hosted-ai-starter-kit/__azurite_db_table__.json","collections":[{"name":"$TABLES_COLLECTION$","data":[],"idIndex":null,"binaryIndices":{"account":{"name":"account","dirty":false,"values":[]},"table":{"name":"table","dirty":false,"values":[]}},"constraints":null,"uniqueNames":[],"transforms":{},"objType":"$TABLES_COLLECTION$","dirty":false,"cachedIndex":null,"cachedBinaryIndex":null,"cachedData":null,"adaptiveBinaryIndices":true,"transactional":false,"cloneObjects":false,"cloneMethod":"parse-stringify","asyncListeners":false,"disableMeta":false,"disableChangesApi":true,"disableDeltaChangesApi":true,"autoupdate":false,"serializableIndices":true,"disableFreeze":true,"ttl":null,"maxId":0,"DynamicViews":[],"events":{"insert":[],"update":[],"pre-insert":[],"pre-update":[],"close":[],"flushbuffer":[],"error":[],"delete":[null],"warning":[null]},"changes":[],"dirtyIds":[]},{"name":"$SERVICES_COLLECTION$","data":[],"idIndex":null,"binaryIndices":{},"constraints":null,"uniqueNames":["accountName"],"transforms":{},"objType":"$SERVICES_COLLECTION$","dirty":false,"cachedIndex":null,"cachedBinaryIndex":null,"cachedData":null,"adaptiveBinaryIndices":true,"transactional":false,"cloneObjects":false,"cloneMethod":"parse-stringify","asyncListeners":false,"disableMeta":false,"disableChangesApi":true,"disableDeltaChangesApi":true,"autoupdate":false,"serializableIndices":true,"disableFreeze":true,"ttl":null,"maxId":0,"DynamicViews":[],"events":{"insert":[],"update":[],"pre-insert":[],"pre-update":[],"close":[],"flushbuffer":[],"error":[],"delete":[null],"warning":[null]},"changes":[],"dirtyIds":[]}],"databaseVersion":1.5,"engineVersion":1.5,"autosave":true,"autosaveInterval":5000,"autosaveHandle":null,"throttledSaves":true,"options":{"persistenceMethod":"fs","autosave":true,"autosaveInterval":5000,"serializationMethod":"normal","destructureDelimiter":"$<\n"},"persistenceMethod":"fs","persistenceAdapter":null,"verbose":false,"events":{"init":[null],"loaded":[],"flushChanges":[],"close":[],"changes":[],"warning":[]},"ENV":"NODEJS"} No newline at end of file | |||
There was a problem hiding this comment.
Bug: Committed DB Exposes Personal Data, Breaks Portability
The __azurite_db_table__.json file is an Azurite database file containing a hardcoded absolute path to a specific user's Google Drive (/Users/vandenbusch/Library/CloudStorage/[email protected]/...). This runtime file exposes personal information and won't work on other machines, indicating it should be in .gitignore rather than committed.
There was a problem hiding this comment.
Pull Request Overview
This PR adds Azurite (Azure Storage Emulator) configuration files to the Azure AI Starter Kit repository. However, both files contain runtime-generated data and local environment-specific information that should not be committed to version control.
Key Issues
- Azurite runtime files are being committed instead of being gitignored
- Configuration contains a spelling error and personal file paths
- These files will cause conflicts across different development environments
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
__azurite_db_table__.json |
Azurite database file containing user-specific absolute paths - should be excluded from version control |
AzuriteConfig |
Azurite instance configuration with a spelling error in the JSON key - should be excluded from version control |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1 @@ | |||
| {"filename":"/Users/vandenbusch/Library/CloudStorage/[email protected]/Geteilte Ablagen/VDB Solutions GmbH /GitHub_2025/self-hosted-ai-starter-kit/__azurite_db_table__.json","collections":[{"name":"$TABLES_COLLECTION$","data":[],"idIndex":null,"binaryIndices":{"account":{"name":"account","dirty":false,"values":[]},"table":{"name":"table","dirty":false,"values":[]}},"constraints":null,"uniqueNames":[],"transforms":{},"objType":"$TABLES_COLLECTION$","dirty":false,"cachedIndex":null,"cachedBinaryIndex":null,"cachedData":null,"adaptiveBinaryIndices":true,"transactional":false,"cloneObjects":false,"cloneMethod":"parse-stringify","asyncListeners":false,"disableMeta":false,"disableChangesApi":true,"disableDeltaChangesApi":true,"autoupdate":false,"serializableIndices":true,"disableFreeze":true,"ttl":null,"maxId":0,"DynamicViews":[],"events":{"insert":[],"update":[],"pre-insert":[],"pre-update":[],"close":[],"flushbuffer":[],"error":[],"delete":[null],"warning":[null]},"changes":[],"dirtyIds":[]},{"name":"$SERVICES_COLLECTION$","data":[],"idIndex":null,"binaryIndices":{},"constraints":null,"uniqueNames":["accountName"],"transforms":{},"objType":"$SERVICES_COLLECTION$","dirty":false,"cachedIndex":null,"cachedBinaryIndex":null,"cachedData":null,"adaptiveBinaryIndices":true,"transactional":false,"cloneObjects":false,"cloneMethod":"parse-stringify","asyncListeners":false,"disableMeta":false,"disableChangesApi":true,"disableDeltaChangesApi":true,"autoupdate":false,"serializableIndices":true,"disableFreeze":true,"ttl":null,"maxId":0,"DynamicViews":[],"events":{"insert":[],"update":[],"pre-insert":[],"pre-update":[],"close":[],"flushbuffer":[],"error":[],"delete":[null],"warning":[null]},"changes":[],"dirtyIds":[]}],"databaseVersion":1.5,"engineVersion":1.5,"autosave":true,"autosaveInterval":5000,"autosaveHandle":null,"throttledSaves":true,"options":{"persistenceMethod":"fs","autosave":true,"autosaveInterval":5000,"serializationMethod":"normal","destructureDelimiter":"$<\n"},"persistenceMethod":"fs","persistenceAdapter":null,"verbose":false,"events":{"init":[null],"loaded":[],"flushChanges":[],"close":[],"changes":[],"warning":[]},"ENV":"NODEJS"} No newline at end of file | |||
There was a problem hiding this comment.
This file contains an absolute path with personal user information (/Users/vandenbusch/Library/CloudStorage/[email protected]/). Azurite database files are typically generated at runtime and should not be committed to version control. Consider adding __azurite_db_table__.json to .gitignore to prevent exposing local development paths and to avoid conflicts between different developers' environments.
| @@ -0,0 +1 @@ | |||
| {"instaceID":"232322a0-e526-489c-8e1f-73123a505dea"} No newline at end of file | |||
There was a problem hiding this comment.
Azurite configuration files are typically generated at runtime and contain instance-specific data. This file should not be committed to version control. Consider adding AzuriteConfig to .gitignore to prevent conflicts between different developers' environments and allow each environment to generate its own configuration.
| @@ -0,0 +1 @@ | |||
| {"instaceID":"232322a0-e526-489c-8e1f-73123a505dea"} No newline at end of file | |||
There was a problem hiding this comment.
Typo in JSON key: "instaceID" should be "instanceID" (missing 'n').
| {"instaceID":"232322a0-e526-489c-8e1f-73123a505dea"} | |
| {"instanceID":"232322a0-e526-489c-8e1f-73123a505dea"} |
1 participant
Note
Adds Azurite emulator config and initializes the local table DB JSON with empty collections.
Written by Cursor Bugbot for commit a960703. This will update automatically on new commits. Configure here.