-
Notifications
You must be signed in to change notification settings - Fork 19
copy triggers in sqlite table recreation #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dariacodes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
tomi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Can we add a test case for this?
Indeed, looking now for where I can add a test case. |
|
@tomi added a test, PTAL! |
tomi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description of change
Copies triggers when recreating a table in SQLite.
Previously, any DSL migration operations that resulted in recreating the table would drop the triggers, because they weren't being properly copied over.
Fixes https://linear.app/n8n/issue/CAT-1709.
Verified in n8n.
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000