Skip to content

Conversation

@mfsiega
Copy link

@mfsiega mfsiega commented Nov 4, 2025

Description of change

Copies triggers when recreating a table in SQLite.

Previously, any DSL migration operations that resulted in recreating the table would drop the triggers, because they weren't being properly copied over.

Fixes https://linear.app/n8n/issue/CAT-1709.

Verified in n8n.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

dariacodes
dariacodes previously approved these changes Nov 4, 2025
Copy link

@dariacodes dariacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Collaborator

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Can we add a test case for this?

@mfsiega
Copy link
Author

mfsiega commented Nov 4, 2025

Looks good 👍 Can we add a test case for this?

Indeed, looking now for where I can add a test case.

@mfsiega
Copy link
Author

mfsiega commented Nov 4, 2025

@tomi added a test, PTAL!

@mfsiega mfsiega requested a review from tomi November 4, 2025 10:05
tomi
tomi previously approved these changes Nov 4, 2025
Copy link
Collaborator

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mfsiega mfsiega merged commit a00104c into master Nov 4, 2025
6 checks passed
@mfsiega mfsiega deleted the preserve-triggers-on-table-recreate branch November 4, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants