This repository was archived by the owner on Jan 17, 2018. It is now read-only.
Fixes issue https://github.com/nallath/PostProcessingPlugin/issues/55.#59
Open
JPFrancoia wants to merge 1 commit intonallath:masterfrom
Open
Fixes issue https://github.com/nallath/PostProcessingPlugin/issues/55.#59JPFrancoia wants to merge 1 commit intonallath:masterfrom
JPFrancoia wants to merge 1 commit intonallath:masterfrom
Conversation
The extruder absolute position is reset to the value it had at te begining of the first layer redone.
Collaborator
|
Developers, see issue CURA-4670. |
Ghostkeeper
reviewed
Dec 19, 2017
| # Get extruder's absolute position at the | ||
| # begining of the first layer redone | ||
| # see https://github.com/nallath/PostProcessingPlugin/issues/55 | ||
| if i == redo_layers: |
Collaborator
There was a problem hiding this comment.
It's probably going to need to be reset before EVERY layer that's being redone, I think, right?
Contributor
Author
There was a problem hiding this comment.
Not sure about what you mean, but my answer is probably "no".
Let's say your Gcode is as follow (2 layers being redone):
layer n-2
E42
layer n-1
E50
Pause
G92 E42 --> that's what the fix does
layer n-2
E42
layer n-1
E50
Basically my code browses the n layers being redone backwards, finds the first one to be redone, get the extruder position, and resets to that value after the pause.
Gcode with 2 layers being redone to prove it "works":
Before, we had this behavior:
layer n-2
E42
layer n-1
E50
Pause
G92 E50 -> position was reset to last extruder position
layer n-2
E42 -> Retraction !!! (50-42)
layer n-1
E50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extruder absolute position is reset to the value it had at the begining of the first layer redone.