Clean up some code, add safety comments and generalize public API of UCI#21
Merged
pulsastrix merged 4 commits intoMay 5, 2026
Merged
Conversation
It was assumed that the &str argument containing the directory was indeed a valid directory, which is likely but not enforced by the API. The corresponding libuci functions are sparsely documented, but the also assume a valid directory name.
Closed
pulsastrix
approved these changes
May 5, 2026
Member
pulsastrix
left a comment
pulsastrix
left a comment
There was a problem hiding this comment.
Hi, thanks for the Pull Request!
This change looks good to me (and is certainly an improvement over the current code), I'll go ahead and merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, and first of all thanks for maintaining this project! Looking to interact with UCI from a project of mine, and stumbled upon this crate. Very happy to be able to write my program using Rust instead of C.
I skimmed through the code, and noticed some things that could be a bit more idiomatic. The biggest change is the type signature of
set_config_dirandset_save_dir, but the change is backwards-compatible by the virtue ofstrimplementingAsRef<Path>.