-
Notifications
You must be signed in to change notification settings - Fork 1.4k
A few zooming in/out with plots display issue fixes. #8199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…er if they're going to be visible. This reduces the relative time delta - thus reducing chances to overflow a Float32
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8199 +/- ##
==========================================
- Coverage 57.34% 56.67% -0.67%
==========================================
Files 704 704
Lines 28322 28353 +31
Branches 2771 2778 +7
==========================================
- Hits 16240 16069 -171
- Misses 11740 11940 +200
- Partials 342 344 +2
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…panning. includes the exact edge points needed (1 before, 1 after visible range)
Closes #7926 #6433 #7928
Describe your changes:
Plots use WebGL to display data points. WebGL (1.0 and 2.0) only work with 32-bit data.
Plots use the 'relative coordinate' strategy to reduce the size of data points (like timestamps in milliseconds) from 64-bit to 32-bit numbers.
This is done by:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist