Skip to content

Conversation

@Viviandavids
Copy link

Work in Progress...

@adowling2
Copy link
Contributor

Is this the final version?

@Viviandavids
Copy link
Author

No, I am about to upload the final copy. Do I upload it the same I did the initial file?

@Viviandavids Viviandavids changed the title Revision of Non Isothermal Packed Bed Reactor Vivian Okorie (Project 1) Nov 3, 2023
@adowling2 adowling2 changed the base branch from main to contributed-notebooks December 5, 2023 20:43
@adowling2
Copy link
Contributor

GitHub will not let me add comments directly on your file, so I will leave feedback here:

  • Please check this table is formatted correctly. It is possible you are violating a Markdown syntax rule but Colab is still able to figure it out for you.

Screenshot 2023-12-06 at 7 40 08 AM

@adowling2
Copy link
Contributor

adowling2 commented Dec 6, 2023

  • The notebook does not have a subsection 1, but it has a subsection 2, etc.

  • Avoid italics or bold in the section, subsection, etc. titles

Screenshot 2023-12-06 at 7 42 31 AM

@adowling2
Copy link
Contributor

  • Please check consistent formatting for all (sub)(sub)section titles. Should this instruction be bold to match earlier in the notebook?

Screenshot 2023-12-06 at 7 43 24 AM

@adowling2
Copy link
Contributor

  • Why did this divide by zero warning occur? If this is expected, please add a sentence explaining to the reader why it happened. Or adjust the bounds for the sensitivity analysis to avoid divide by zero.

Screenshot 2023-12-06 at 7 45 07 AM

@adowling2
Copy link
Contributor

  • Please also fix this warning message. Or if you intentionally want this warning message to occur, you need to explain and interpret it for the user.

Screenshot 2023-12-06 at 7 46 40 AM

@adowling2
Copy link
Contributor

  • Please provide answers to all of the discussion questions.

@Viviandavids
Copy link
Author

Viviandavids commented Dec 6, 2023 via email

@Viviandavids
Copy link
Author

Viviandavids commented Dec 6, 2023 via email

The table displays properly on Visual studio code. The runtime has been resolved. The sections and subsections now have a consistent heading font size.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants