Skip to content

Conversation

@ShZhang01
Copy link

Update the code for installing Ipopt and Pyomo; Add some description on the variables; Add a sensitive analysis code.

@ShZhang01
Copy link
Author

@adowling2

@ShZhang01 ShZhang01 changed the title Added minor changes in "Diffusion with Adsorption in Polymers" Project Sam Zhang- "Diffusion with Adsorption in Polymers" Project Nov 3, 2023
@adowling2 adowling2 changed the base branch from main to contributed-notebooks December 5, 2023 20:41
@adowling2 adowling2 changed the title Sam Zhang- "Diffusion with Adsorption in Polymers" Project Sam (Project 1) Dec 5, 2023
@adowling2
Copy link
Contributor

adowling2 commented Dec 6, 2023

Due to a quirk in GitHub, I am providing feedback here instead of in comments.

  • Provide mathematical analysis to show this transformation works:

Screenshot 2023-12-06 at 8 23 04 AM

@adowling2
Copy link
Contributor

  • Do not plot as part of the sensitivity analysis

Screenshot 2023-12-06 at 8 24 05 AM

@adowling2
Copy link
Contributor

  • No discussion of the sensitivity analysis results. Why are they significant? A question is prosed in the Gradescope submission by not the notebook. The notebook should both ask and answer the discussion question.

@adowling2
Copy link
Contributor

adowling2 commented Dec 6, 2023

  • Why is this happening in the sensitivity analysis results?

Screenshot 2023-12-06 at 8 29 02 AM

This looks like the numerical solution did not converge:

Screenshot 2023-12-06 at 8 30 06 AM

@adowling2
Copy link
Contributor

  • Intellectual contribution is well below standards.

The sensitivity analysis results need to be interpreted/structured to advance the learning objective of the notebook.

A better option than the sensitivity analysis would have been extending the notebook to answer these exercises:

Screenshot 2023-12-06 at 8 31 46 AM

@adowling2
Copy link
Contributor

adowling2 commented Dec 6, 2023

  • Need to add learning objectives, target audience, etc. See project description and other examples.

@adowling2
Copy link
Contributor

  • Figures are not publication quality, see guidelines

@ShZhang01
Copy link
Author

@adowling2 Hi Prof.Dowling, Here is my sincere apology for missing the submission of revised project 1 on Wednesday. Due to the final week's intensive review task, I really misunderstood the deadline to be on Friday. I started revising it immediately upon receiving the comments and have spent a lot of time and thinking on it. I deeply realize that I have not performed well in this class and nearly miss the final chance to rectify it, but I am hoping and really appreciate if you can give me a chance to consider my late submission. Really sorry for any inconvenience it may cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants