Fix off-by-one in <File> line-range extraction and add regression test#2971
Open
afurm wants to merge 1 commit intonear:masterfrom
Open
Fix off-by-one in <File> line-range extraction and add regression test#2971afurm wants to merge 1 commit intonear:masterfrom
afurm wants to merge 1 commit intonear:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<File ... start="x" end="y" />snippet extraction had an off-by-one bug that included one extra line afterend.This PR:
enddoes not include the next linestart="2" end="3"to ensure only lines 2–3 are returnedrequire.mainguard/export so the helper can be tested directly without changing normal script executionBefore / After
start=2, end=3returned lines2, 3, 4start=2, end=3returns lines2, 3Testing