Repository navigation
feat(node): join V2 signing rounds only from acting leaders - #5143
Draft
haiyuechen-nearone wants to merge 8 commits into
Conversation
…t' into 5124-accept-v2-foreign-tx-attempts-only-from-acting-leaders Resolve toward the collect first model: take the lower branch's open requests, signing round and test files, drop the attempt follower and its tests, and keep the acting leader check with the index time of each open request on top.
…r request and leader
…t' into 5124-accept-v2-foreign-tx-attempts-only-from-acting-leaders Keep the acting leader check and the round cap next to the new evidence size check of the signer. Build the provider of the inspection tests from the shared test support too.
… acting leader to its request
haiyuechen-nearone
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5124
A V2 signer joins a signing round only when the node that sent Start is an acting leader of the request in its view, and at most three rounds per request and leader.
Reviewer notes:
ensure_acting_leaderreturns anActingLeaderproof bound to the request, andjoin_roundtakes only that proof. The signer checks the leader before it waits for the evidence, and counts the round last, so a refused round uses up nothing.A backup's turn is timed from the signer's own index time, accepted up to 3 seconds early.
One counter covers verdict and inconclusive rounds. feat(node): sign an inconclusive when no V2 verdict can reach the threshold #5145 calls it on the inconclusive path.
queue.rswas already over 1,000 lines.open_requests.rstests moved to their own file.