Skip to content

revisit accessibilityRole=button to button mapping #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
intergalacticspacehighway wants to merge 1 commit into from
Closed

revisit accessibilityRole=button to button mapping #1944

intergalacticspacehighway wants to merge 1 commit into from

Conversation

@intergalacticspacehighway
Copy link
Contributor

@intergalacticspacehighway intergalacticspacehighway commented Mar 17, 2021 •
edited
Loading

Issue link

  • Tested example and updated test cases.
  • Verified reset styles, tabIndex, and disabled props.

@jgornick jgornick mentioned this pull request Apr 13, 2021
Closed
@jerrywithaz
Copy link

jerrywithaz commented Jul 20, 2022

@necolas @louis-burrows if the merge conflicts in this get fixed, would you all accept this pr? It would great if buttons were actually rendered instead of div's

@necolas necolas added this to the 0.19: React 18 milestone Aug 25, 2022
@necolas necolas added project:react-native-web Issue associated with react-native-web has: pr Subject of a pull request labels Aug 29, 2022
necolas added a commit that referenced this pull request Sep 1, 2022
@necolas
[change] Map 'button' and 'paragraph' role to HTML elements
80ca507 
Fix #1899
Close #1944
necolas added a commit that referenced this pull request Sep 1, 2022
@necolas
[change] Map 'button' and 'paragraph' role to HTML elements
234a114 
Fix #1899
Close #1944
necolas added a commit that referenced this pull request Nov 28, 2022
@necolas
[change] Map 'button' and 'paragraph' role to HTML elements
13bf34e 
Fix #1899
Close #1944
necolas added a commit that referenced this pull request Dec 27, 2022
@necolas
[change] Map 'button' and 'paragraph' role to HTML elements
20c50cb 
Fix #1899
Close #1944
@parasharrajat parasharrajat mentioned this pull request Jan 11, 2023
Closed
1 task
@s77rt
Copy link
Contributor

s77rt commented Jan 11, 2023

This may not work as you'd expect, in our case we had <div>s rendered inside <button> which is semantically incorrect.

@necolas necolas closed this in e8a0cbc Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@louis-burrows louis-burrows louis-burrows approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

has: pr Subject of a pull request project:react-native-web Issue associated with react-native-web

Projects

None yet

Milestone

0.19: React 18

Development

Successfully merging this pull request may close these issues.

5 participants

@intergalacticspacehighway @jerrywithaz @s77rt @louis-burrows @necolas