Skip to content

Conversation

@cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Dec 17, 2025

Description

Add support for macOS checks and Optimized Windows and ubuntu. Fixed Coveralls configured mstesting for it.

image

Change Log

  • Modified File main.yml
  • Modified File tests\Directory.Build.props

Fixes # (issue)

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Testing
  • Run Application
  • Local Computer Tests
  • No Testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Added configurations of tests
Added macOS tests and fixed linux and windows
@erikzhang
Copy link
Member

I prefer to dynamically add the Coverlet reference in GitHub Actions rather than in the .csproj file.

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Dec 18, 2025

I prefer to dynamically add the Coverlet reference in GitHub Actions rather than in the .csproj file.

We had problems in the pass that where the format of the *.info file is in a different format and file merging problems. Also all tests require it, so it would be easier to do this way in tests/Directory.Build.props. But sure i can add it to the github-action if you really want.

@erikzhang
Copy link
Member

We had problems in the pass that where the format of the *.info file is in a different format and file merging problems.

Only *.json and be merged. That's why I set the output format to lcov,json. It works perfectly.

@cschuchardt88
Copy link
Member Author

We had problems in the pass that where the format of the *.info file is in a different format and file merging problems.

Only *.json and be merged. That's why I set the output format to lcov,json. It works perfectly.

Ok, ill look into it and change it back

@shargon
Copy link
Member

shargon commented Dec 22, 2025

I prefer to dynamically add the Coverlet reference in GitHub Actions rather than in the .csproj file.

me too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants