-
Notifications
You must be signed in to change notification settings - Fork 224
Fix: unify Grpc dependency #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master-n3
Are you sure you want to change the base?
Conversation
|
require #945 |
|
It will possibly solve #942, but other loading problems will remain, we can address later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in this specific case, but related.
Does SignPlugin needs to specify all these versions listed below?
<PackageReference Include="Grpc.Net.Client" Version="2.71.0" />
<!-- NOTE: Need install rosetta2 on macOS ARM64 -->
<PackageReference Include="Grpc.Tools" Version="2.76.0" PrivateAssets="all" /```
Other versions are also OK. |
|
I mean, do we need to really specify each sub-library of GRPC in SignPlugin? @shargon Do we really need this for safety? |
Optimized. |
|
How about GRPC tools still in a different version? |
|
I think the core to solving this problem is to load each plugin into a different AppDomain, so that they can avoid interfering with each other. |
|
@erikzhang, I think that different AppDomain solves this dependencies problems in way that each plugin could indeed have its own packages without conflicts. Additionally, we still have plugins that depends on each other, for example plugins that depends on RPCServer. |
|
In any case, although its is important and good to create a better design of these plugins loading and its domains, this is not really critical. |
Agree, but we tried with lot of erros, because we need to comunicate between plugins |
What kind of communication? |
There are different Grpc dependency versions.
So add this to unify Grpc dependency.