Make Public Buffer.InvalidateHashCode
#544
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
ajara87
approved these changes
Dec 15, 2025
|
It's better not to cache the hashcode for mutable item. |
erikzhang
requested changes
Dec 16, 2025
Member
erikzhang
left a comment
erikzhang
left a comment
There was a problem hiding this comment.
Why does it need a hash code? It can't be a key of a dictionary. As well as CompoundType, they don't need a GetHashCode(). Use the default one, or just throws NotSupportedException.
Member
Author
Is mutable, it's a bad key for a dictionary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it's possible to change the InnerData, it should be possible to invalidate the hashcode or we can produce errors, and it is not possible to replicate in a new jump table some behaviors
Required for neo-project/neo#4381