-
Notifications
You must be signed in to change notification settings - Fork 1k
Optional snapshot in GetScriptHashesForVerifying
#4378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shargon
merged 5 commits into
neo-project:master
from
shargon:n4-verificable-snapshot-optional
Dec 16, 2025
Merged
Optional snapshot in GetScriptHashesForVerifying
#4378
shargon
merged 5 commits into
neo-project:master
from
shargon:n4-verificable-snapshot-optional
Dec 16, 2025
+84
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikzhang
reviewed
Dec 15, 2025
Member
erikzhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When explicitly implementing an interface method, default values should not be provided for the parameters.
shargon
commented
Dec 15, 2025
Remove default Co-authored-by: Erik Zhang <[email protected]>
ajara87
reviewed
Dec 15, 2025
Add unit tests
Member
Author
|
Merge? |
Member
Wait. |
erikzhang
approved these changes
Dec 16, 2025
cschuchardt88
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of review neo-project/neo-node#946
Only one class use the snapshot, so it's changed to be optional
Type of change
How Has This Been Tested?
Checklist: