Skip to content

Conversation

@shargon
Copy link
Member

@shargon shargon commented Dec 14, 2025

Description

Part of review neo-project/neo-node#946
Only one class use the snapshot, so it's changed to be optional

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Testing
  • Run Application
  • Local Computer Tests
  • No Testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the N4 label Dec 14, 2025
@shargon shargon added Port-to-3.x Feature or PR must be ported to Neo 3.x branch Waiting for Review and removed N4 labels Dec 14, 2025
Copy link
Member

@erikzhang erikzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When explicitly implementing an interface method, default values ​​should not be provided for the parameters.

Remove default

Co-authored-by: Erik Zhang <[email protected]>
@github-actions github-actions bot added the N4 label Dec 15, 2025
@shargon
Copy link
Member Author

shargon commented Dec 16, 2025

Merge?

@erikzhang
Copy link
Member

Merge?

Wait.

@shargon shargon merged commit 567275d into neo-project:master Dec 16, 2025
7 checks passed
@shargon shargon deleted the n4-verificable-snapshot-optional branch December 16, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

N4 Port-to-3.x Feature or PR must be ported to Neo 3.x branch Ready to Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants