-
Notifications
You must be signed in to change notification settings - Fork 5
Introduce application/vnd.neo4j.query.v1.1 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce application/vnd.neo4j.query.v1.1 #9
Conversation
This version introduces VECTOR and UNSUPPORTED types.
| The dimension of the `VECTOR` is implicitly defined by the length of the `coordinates` array. | ||
|
|
||
| | UNSUPPORTED | ||
| | Unsupported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All drivers called this UnknownType. Are we sure we don't want to do the same in this API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The java driver expose in the type system as UNSUPPORTED, so we changed to match them. See, https://github.com/neo4j/neo4j-java-driver/blob/6.x/driver/src/main/java/org/neo4j/driver/types/UnsupportedType.java.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand it the class type users get exposed to is https://neo4j.com/docs/api/java-driver/current/org.neo4j.driver/org/neo4j/driver/internal/value/UnsupportedTypeValue.html , which implements https://neo4j.com/docs/api/java-driver/current/org.neo4j.driver/org/neo4j/driver/types/UnsupportedType.html. UNSUPPORTED is the Bolt name, or?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value goes into a field called $type, so call it UNSUPPORTED instead of UNSUPPORTED TYPE removes the redundancy.
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
This version introduces VECTOR and UNSUPPORTED types.