feat: allow some relation nodes to not define key/unique properties #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbiville
force-pushed
the
flexible_node_keys
branch
2 times, most recently
from
156e43c to
0ec69d6
Compare
This commit relaxes validation `NKRN-001`, which, until now, required that every node target, referenced by a relationship, defines at least one key or unique constraint. The validation now allows such node targets to not define any key or unique constraints themselves, if and only if another node's key or unique constraint covers some of its labels and properties. If the node reference overrides the mappings for key properties, all these properties must be matched by key or unique constraints defined elsewhere for any of the node labels. Signed-off-by: Florent Biville <[email protected]>
fbiville
force-pushed
the
flexible_node_keys
branch
from
0ec69d6 to
395131a
Compare
fbiville
commented
Nov 23, 2025
core/src/main/java/org/neo4j/importer/v1/util/collections/Sets.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit relaxes validation
NKRN-001, which, until now,required that every node target, referenced by a relationship,
defines at least one key or unique constraint.
The validation now allows such node targets to not define any key
or unique constraints themselves, if and only if another node covers
some of its labels and properties.
If the node reference overrides the mappings for key properties,
all these properties must be matched by key or unique constraints
defined elsewhere for any of the node labels.